Cover react/renderer/leakchecker with Stable API guards - #58090
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover react/renderer/leakchecker with Stable API guards#58090j-piasecki wants to merge 1 commit into
react/renderer/leakchecker with Stable API guards#58090j-piasecki wants to merge 1 commit into
Conversation
Summary: Classifies `react/renderer/leakchecker:leakchecker` as a private target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include its headers; without that flag the guards are inert, so no existing build changes behaviour. The pod that ships the module, `React-Fabric`, already depends on `React-cxxstableapi` and is already marked as a React Native build, so no podspec change is needed. Changelog: [Internal] Differential Revision: D117188751
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117188751. |
cortinico
approved these changes
Aug 24, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in a106fdf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/leakchecker:leakcheckeras a private target under the three-tier C++ stable API visibility model. Consumers that opt intoRN_STRICT_APInow get an error if they include its headers; without that flag the guards are inert, so no existing build changes behaviour. The pod that ships the module,React-Fabric, already depends onReact-cxxstableapiand is already marked as a React Native build, so no podspec change is needed.Changelog: [Internal]
Differential Revision: D117188751